modularizing code

[mediarare]

What kinds of things can I count on not working in a modular form.

I ask mostly because i was just modifing a fm 6 app for a client and found a situation where modularizing a 13 step script would save me alot of time. The script how ever did a slightly different find depending on a custom dialog box. Even though this script is called by scripts in the same file it seemed to ignore my find requests.

what else should i expect not to work?

[SteveB]

You have something that is not right. Modularizing a script shouldn't impact results, and is the proper approach.

Steve

[mediarare]

You have something that is not right. Modularizing a script shouldn't impact results, and is the proper approach.

Steve

I didn't think I was doing anything wrong. but putting the script steps inline makes it work again. Basically the script is this:

show a custom dialog with 3 options

if option 2

enter find mode

set the field i'm searching on to what i dont want it to be

omit the record

perform the find with constrain set no restor find requests

else

if option 3

enter find mode

set the field i'm searching on to what i want it to be

perform the find with constrain set no restor find request

end if

end if

The previous dev did it in a couple places but my client wanted to expand this to several other reports so I thought I'd save myself some time and modularize it and it backfired.

If that raises any flags I'd love to know what I did wrong.

[Ender]

And the modularization was??

[mediarare]

sorry for the delay, I typed up a nice responce and then the forums where put into maintence mode on me and I lost all I typed up so here we go.

Attached are screen shots of the scripts, they are in the state i had to leave them with the code inline rather than modularized. the "Print Mastery List for Group" calls the "Print Mastery List by Group Report". These scripts are in seperate files.

I tried to modularize the 13 lines in "Print Mastery List by Group Report" that start with show custom dialog and stops at the second end if. That would make it a third level script.

This makes me wonder if there's a limit to how many scripts can be called or something since the my constraining find would work inline as it is in the screen shots but when I seperate it into it's only sub script that it doesn't.

Mostly I'd like to figure out why this didn't work for future referance as I just replicated the script steps I wanted to modularize into the 6 places I needed it to be and gave the application back to the client. I just can't see what would over-ride my constraining find if I break it into a module.

[Ender]

You indicated this problem was happening in the v7 database, but the screenshots you provided are from FM5 or 6. There are several script steps that work a little different in FM7, including Perform Script (subscripts are always performed in FM7,) and Go to Related Record[]. Also in FM7v1, if no records were found, the previous found set would be shown. Any of these are possible issues, but it's hard to tell from your FM5/6 scripts.

Perhaps you could mock up a demo showing how this works when the steps are inline and it fails when the scripts are in a subscript.

[mediarare]

I'm sorry, This issue is with fm dev 6 as the screen shots portray. I should have been more clear on this being in dev 6.

The client is using some plugins that are not ready for fm 7 that interface with a scantron test scanner as well as some plugin that does some text stuff.

I'll just mark this one up as a weird instance and not worry about it since I didn't develop this one from scratch.