Can anyone think of the pro's / con's between:

 

a) Custom script attached to "close window" (set in a custom menu)

Custom script attached to OnWindowClose (set in File Options, script triggers)

Well, OnLastWindowClosed is automatic and doesn't require any mouse clicks. Or perhaps I misunderstand the question . . .

Well they do the same thing.

 

If a user hits cmd-w, or clicks the close box, or selects file-->close window

 

The only difference I can see is that the script step "close window" will NOT trigger a custom menu, but WILL trigger OnCloseWindow.

 

Usually, when there's two ways to do something, there's pros and cons to each.

 

For example, a layout trigger of OnModeEnter (say, for entering find mode) works very differently to a custom menu attached to View-->Find menu. If you trigger a script to View-->Find, you can perform functions BEFORE you enter Find mode whereas the layout trigger will only trigger after entering Find Mode.

 

But with closing windows, I can't see why they've put the same function in two different places.

I see. I normally just quit the program thereby triggering all the closing scripts.